Removed the confirmation of mention selection by using the space key

[fredck]

Suggested merge commit message (convention)

Other (mention): The space keys is not anymore used to confirm a mention selection from the list. Closes #6394.

---

Additional information

Original PR: ckeditor/ckeditor5-mention#92

[ghost]

@fredck
Why not doing the same with keyCodes.space as with keyCodes.esc, calling this._hideUIAndRemoveMarker();? e.g. in github when using the @, if you enter space after the @, the menu goes away....

[fredck]

Why not doing the same with keyCodes.space as with keyCodes.esc, calling this._hideUIAndRemoveMarker();? e.g. in github when using the @, if you enter space after the @, the menu goes away....

@pammann-work, I'm not sure I've understood this. With the provided patch, if you enter space after @ the menu goes away, exactly as you described. In fact, the final behavior will match exactly what you see in GitHub. Am I missing something?

[ghost]

@fredck, good to hear to it will work like in GitHub. I was just looking at the code changes and did not try it out. Thanks for your confirmation.

[robjbrain]

I came to this issue by following a path of closed issues
#4665 (comment)
ckeditor/ckeditor5-mention#92 (comment)

The original request was that we be able to mention names that have a space in them e.g. "John Doe" rather than closing the mention dialog after typing the space in "John ".

I can see that this change was merged and I can see the updated code in my node_modules directory so i'm definitely up to date but the functionality is still the same, the menu is closed when a space is typed.

Is there a solution that prevents the menu from closing on a space?

[EricPaulson]

This PR does not solve the problem. As soon as I press the spacebar, the mention dropdown disappears. This is not how any user would expect this feature to work.