-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon for ImageResizeUI plugin #7559
Comments
TBH for individual icons, I'd rather go with something like this (this is not a final mockup, though). The percentage could be next to an icon and we could provide a couple of icons (4 or 5 stops would be enough I think?) and developers could use them in the configuration.
As for the drop-down, I think we can reduce its width to something sane (3 digits + unit) but keep it fixed to prevent from drop-down re-scaling as they change from "2 digits + unit" to "3 digits + unit". I didn't follow the original PR so I don't know which values are available. I think we could use the "medium" icon (from my mock-up) for the drop-down and it should do the trick. I'd need to see it in action to give you yay or nay, though. |
I like the set of icons here, but I think they don't match the meaning of the feature. They look more like But I agree that the main case here is to have |
Notes from internal meeting:
+ part of #7560:
|
Internal (image): Improved the `ImageResizeUI` plugin UI. Added dedicated icons for each option (small, medium, large and original) and the dropdown (dropdown icon). Closes #7559. Internal (image): Improved the screen reader experience for the `ImageResizeUI` standalone buttons configured via `config.image.toolbar` (see #7559). Other (core): Added icons that represent different sizes of an object (`object-size-*.svg`) (see #7559).
We just introduced the new plugin
ImageResizeUi
which allows the users to manually change the size of an image based on the given configuration.The plugin may be displayed as a dropdown or a set of standalone buttons.
First attempt for the icon looked like:
and
The concept of the icon above looks OK with a dropdown but we're not sure whether we want to display the icon for every standalone button...
The question is:
cc @oleq
The text was updated successfully, but these errors were encountered: