-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I/7559: Update ImageResizeUI plugin #7616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phew... I fixed them all 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I improved some docs and refactored the code a little bit. Still:
- Localization entries are missing.
- Missing changelog entry for ckeditor5-core.
- Docs are bleeding (CKEditorError: imageresizeui-missing-icon) http://fake.ckeditor.com/ck/5/ckeditor5/build/docs/ckeditor5/latest/features/image.html#resizing-images.
@ckeditor/qa-team Can you take a look at this PR? Thanks 🙏 |
Fixed it. |
I reported a bug with jumping blue border, which occurs also on master ( and since a long time ), but it gets much more visible when using those new buttons for resizing. Original issue: #7633 Screencast: |
Apart from what I mentioned above, everything seems to be ok 👍 |
Suggested merge commit message (convention)
Other (image): Improved
ImageResizeUI
plugin UI. Added the dedicated icons for each option (small
,medium
,large
andoriginal
) and the dropdown (dropdown icon). Closes #7559.Other (image): Improved screen reader experience for
ImageResizeUI
standalone buttons in theimage.toolbar
.Other (core): Added icons that represent the size of the element (
object-size-*
).