-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's almost impossible to click certain buttons in the balloon toolbar (Safari, iOS) #7707
Comments
An afterthought/rough idea: what if we made the balloon triangle bigger to increase the distance between the selection handle and the buttons? |
We can also just move this balloon ~5px-10px lower/higher on iOS. |
@oleq said that we'd have to move it by ~20px to make a difference. In this case, should we hide the arrow? |
Let's do this after #9892. |
Scope:
|
@oleq interesting... how did you determine the size of this area? By trial and error clicking around? |
Yep. I'll post my PoC to address this issue later today. |
PoC branch #10736. FindingsHow it looks when zoomed out How it looks when zoomed in I had to restrict the number of available positions because some of them look weird when the balloon is far away and arow-less. I left only some basic ones (centered and extremes), dropped "middle" ones etc. This will make the toolbar more likely to go off the screen, so it's a sort of trade-off Other than this, I tried to limit the fix to the |
Out of curiosity – does the viewport API tell us about the position of the native balloon? How does it work now that our balloon is placed on the opposite side of the selection than the native one? Is it intentional or somehow accidental? My two other random thoughts:
|
BTW, did you move the balloon completely beyond the range of the selection "pin" clickable area? Maybe we don't have to move it completely outside, but just a bit further so the overlapping area is smaller? Thus, we'd reduce a bit the distance and maybe it'd look less odd (to me :P). |
I moved it far enough for the entire button to be clickable. And I agree, this looks weird. |
Or maybe it's not about the distance but about the lack of the triangle (arrow) that would give it context. |
Awaiting feedback from the team on #10736. |
Fix (ui): Changed the look and position of the `BalloonToolbar` in Safari on iOS to avoid a clash with native text selection handles. Closes #7707. Feature (utils): Introduced `env.isiOS` for detection of user agents running in iOS (see #7707). Internal (utils,minimap): Moved the `RectDrawer` dev helper from `ckeditor5-minimap` to `ckeditor5-utils`.
📝 Provide detailed reproduction steps (if any)
✔️ Expected result
All toolbar buttons should be clickable.
❌ Actual result
For some unknown reason buttons next to the selection handler cannot be clicked as if something covered them (native iOS behavior/optimization next to selection handles?).
📃 Other details
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: