Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table toolbar does not respect viewportTopOffset configuration #9892

Closed
oleq opened this issue Jun 16, 2021 · 0 comments · Fixed by #10373
Closed

Table toolbar does not respect viewportTopOffset configuration #9892

oleq opened this issue Jun 16, 2021 · 0 comments · Fixed by #10373
Assignees
@dawidurbanski
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 47 (v30...

Comments

@oleq
Copy link
Member

oleq commented Jun 16, 2021

📝 Provide detailed reproduction steps (if any)

Use a table longer than the viewport to reproduce the issue. In the screenshot below, I reduced the opacity of the documentation top bar to show the actual position of the toolbar. It should attach to the bottom of the page top bar just like the main editor toolbar does.

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. package:table domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. squad:core Issue to be handled by the Core team. labels Jun 16, 2021
@AnnaTomanek AnnaTomanek added this to the backlog milestone Jun 21, 2021
@Reinmar Reinmar modified the milestones: backlog, iteration 45 Jul 5, 2021
@dawidurbanski dawidurbanski mentioned this issue Jul 9, 2021
Closed
@AnnaTomanek AnnaTomanek mentioned this issue Jul 13, 2021
Closed
@oleq oleq modified the milestones: iteration 45, iteration 46 Jul 28, 2021
@oleq oleq mentioned this issue Jul 28, 2021
Closed
@AnnaTomanek AnnaTomanek mentioned this issue Aug 4, 2021
Closed
@Reinmar Reinmar removed the intro Good first ticket. label Aug 9, 2021
@dawidurbanski dawidurbanski mentioned this issue Aug 10, 2021
Closed
@Reinmar Reinmar mentioned this issue Aug 18, 2021
Closed
@martynawierzbicka martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Aug 19, 2021
@dawidurbanski dawidurbanski mentioned this issue Aug 23, 2021
Merged
@AnnaTomanek AnnaTomanek mentioned this issue Sep 6, 2021
Closed
@AnnaTomanek AnnaTomanek modified the milestones: iteration 46, iteration 47 Sep 6, 2021
@Reinmar Reinmar mentioned this issue Sep 14, 2021
Closed
oleq added a commit that referenced this issue Sep 22, 2021
@oleq
Other: The viewport offsets will be taken into consideration when cal…
00c7cfd 
…culating the position of contextual balloons (such as the table toolbar). Closes #9892.

Feature (ui): Introduced a new position type (`viewportStickyNorth`) in `BalloonPanelView.defaultPositions`. See #9892.

MINOR BREAKING CHANGE (widget): Removed the `centeredBalloonPositionForLongWidgets()` helper from widget utils. Use `BalloonPanelView.defaultPositions.viewportStickyNorth` instead. See #9892.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dawidurbanski dawidurbanski

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 47 (v30.0.0)
5 participants
@Reinmar @AnnaTomanek @oleq @dawidurbanski @martynawierzbicka