-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better formatting of custom errors #8140
Comments
cc @jodator |
Another thing to improve - error with params. |
And check the test for proper format: #8124 (comment). |
I wonder if we could learn something from other projects here. Maybe there are some tricks that could improve the readability even further. BTW, one of these things would be if we were able to shorten the URL as it obscures the view... But I guess this is not easily doable. |
Custom URL shortener 😉 https://www.youtube.com/watch?v=Z57566JBaZQ. But we could check how to improve in other repos for sure. |
I've played a bit with this - I'd go with a two-line message:
👍 Pros:
👎 Cons:
|
It seems that 3 👍 is enough :) Thanks! |
Did you create a PR for this? I can see it's on review but I can't find any linked PR. |
OMG Sorry - I was 100% sure that the PR was created because I've updated the PR in |
Other (utils): Make custom errors more readable in the console. Closes #8140. MINOR BREAKING CHANGE (utils): The `attachLinkToDocumentiation()` helper was removed. To log errors to the console with attached link to the documentation use `logWarning()` and `logError()`.
📝 Provide a description of the improvement
Right now an error prints like this:
It was formatted slightly better in the past because there was a period after the message
We don't have the message now but we have to separete "Read more" from the error code somehow. Some ideas:
CKEditorError: error-code | Read more: URL
CKEditorError: [error-code] Read more: URL
CKEditorError: error-code -> Read more: URL
If you'd like to see this improvement implemented, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: