Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use same format for error name in attachLinkToDocumentation as in CKEditorError #8124

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Use same format for error name in attachLinkToDocumentation as in CKEditorError #8124

merged 3 commits into from
Sep 24, 2020

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Sep 22, 2020 •
edited
Loading

Suggested merge commit message (convention)

Internal: Use same format for error name in attachLinkToDocumentation as in CKEditorError. Closes #8097.

Additional information

@jodator jodator mentioned this pull request Sep 22, 2020
Closed
@jodator
Copy link
Contributor Author

jodator commented Sep 22, 2020

Looks like only the documentation is failing on the CI so not related to this change.

@jodator jodator marked this pull request as ready for review September 23, 2020 10:18
@mlewand mlewand self-requested a review September 24, 2020 09:41
@jodator jodator mentioned this pull request Sep 24, 2020
Closed
mlewand
mlewand approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, I was unbale to find any other error instances.

There are instances in collaboration/external projects though - do we have a ticket for that already?

@mlewand mlewand merged commit 7792bec into master Sep 24, 2020
@mlewand mlewand deleted the i/8097 branch September 24, 2020 10:59
@jodator
Copy link
Contributor Author

jodator commented Sep 24, 2020

There are instances in collaboration/external projects though - do we have a ticket for that already?

AFAICS there was no use of attachLinkToDocumentation elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reinmar Reinmar Reinmar left review comments

@mlewand mlewand mlewand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Followups for the changes in error codes
3 participants
@jodator @Reinmar @mlewand