Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserting image above html embed and changing its align will result in increasing html embed height #8324

Closed
pkwasnik opened this issue Oct 22, 2020 · 1 comment
Closed

Inserting image above html embed and changing its align will result in increasing html embed height #8324

pkwasnik opened this issue Oct 22, 2020 · 1 comment
Assignees
@pkwasnik
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:html-embed package:image release:potential-blocker This issue potentially blocks the upcoming release (should be checked). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 37 (v23...

Comments

@pkwasnik
Copy link
Contributor

pkwasnik commented Oct 22, 2020 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

  1. insert html embed
  2. insert image above html embed
  3. change image align to left or right

✔️ Expected result

Image change align, but html embed will stay unchanged.

❌ Actual result

HTML embed increase its height covering image.

📃 Other details

  • Browser: Chrome, Firefox
  • OS: Windows
  • CKEditor version: 23.0.0
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@pkwasnik pkwasnik added type:bug This issue reports a buggy (incorrect) behavior. package:html-embed package:image domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels Oct 22, 2020
@Reinmar Reinmar added the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Oct 23, 2020
@pkwasnik pkwasnik mentioned this issue Oct 23, 2020
Merged
pomek added a commit that referenced this issue Oct 23, 2020
@pomek
Merge pull request #8330 from ckeditor/i/8324
d8b26da 
Internal (html-embed): The HTML snippet widget will not cover the image inserted above with the alignment style. Closes #8324.
@pomek
Copy link
Member

pomek commented Oct 23, 2020

Fixed by #8330.

@pomek pomek closed this as completed Oct 23, 2020
@pomek pomek added this to the iteration 37 milestone Oct 23, 2020
@oleq oleq mentioned this issue Oct 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkwasnik pkwasnik

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:html-embed package:image release:potential-blocker This issue potentially blocks the upcoming release (should be checked). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 37 (v23.1.0)
Development

No branches or pull requests
3 participants
@Reinmar @pomek @pkwasnik