Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit HTML embed styles around floated elements #8332

Closed
oleq opened this issue Oct 23, 2020 · 0 comments · Fixed by #8379
Closed

Revisit HTML embed styles around floated elements #8332

oleq opened this issue Oct 23, 2020 · 0 comments · Fixed by #8379
Assignees
@pkwasnik
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:html-embed squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 38 (v24...

Comments

@oleq
Copy link
Member

oleq commented Oct 23, 2020

Provide a description of the task

A follow-up of #8324 which was hot-fixed by #8330.

The solution in the hotfix is not perfect because it disables floating elements around HTML embeds. A better solution (similar to the horizontal line widget) is described in the comment below the PR.

ATM

Expected

📃 Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …
@oleq oleq added type:task This issue reports a chore (non-production change) and other types of "todos". intro Good first ticket. domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. package:html-embed labels Oct 23, 2020
@oleq oleq mentioned this issue Oct 23, 2020
Merged
@Mgsy Mgsy added this to the nice-to-have milestone Oct 26, 2020
@AnnaTomanek AnnaTomanek modified the milestones: nice-to-have, iteration 38 Oct 26, 2020
@pkwasnik pkwasnik self-assigned this Oct 29, 2020
@pkwasnik pkwasnik mentioned this issue Oct 29, 2020
Merged
jodator added a commit that referenced this issue Oct 30, 2020
@jodator
Merge pull request #8379 from ckeditor/i/8332
985334c 
Fix (html-embed): Floated images are now properly displayed around HTML embeds. Closes #8332.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkwasnik pkwasnik

Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:html-embed squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 38 (v24.0.0)
Development

Successfully merging a pull request may close this issue.

Revisit HTML embed styles around floated elements ckeditor/ckeditor5
4 participants
@AnnaTomanek @oleq @pkwasnik @Mgsy