Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editable gets a weird extra scroll when it ends with a small HTML embed #8340

Closed
Reinmar opened this issue Oct 26, 2020 · 4 comments · Fixed by #8550
Closed

Editable gets a weird extra scroll when it ends with a small HTML embed #8340

Reinmar opened this issue Oct 26, 2020 · 4 comments · Fixed by #8550
Assignees
@niegowski
Labels
package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 38 (v24...

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 26, 2020

📝 Provide detailed reproduction steps (if any)

  1. Create content that and with an HTML embed that has only e.g. one character.
  2. Put the selection in a content preceding that embed.

✔️ Expected result

The editable should have no scroll as it's not styled with any overflow and height limitations.

❌ Actual result

Bonus point. In our docs the scroll appears only when the widget is not selected. In manual tests I can see that the scroll changes its height but it's shown in both cases.

📃 Other details

This happens on every browser. 

I tried to figure out what's leaking out of the embed but I couldn't. My wild guess is that it may be something with using flex, but I can be very wrong.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. squad:core Issue to be handled by the Core team. package:html-embed labels Oct 26, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Oct 26, 2020
@AnnaTomanek AnnaTomanek modified the milestones: nice-to-have, iteration 38 Oct 26, 2020
@niegowski
Copy link
Contributor

Is this issue still valid? I wasn't able to reproduce it.

@niegowski
Copy link
Contributor

Ok, a tooltip for the edit button is causing this.

@Reinmar
Copy link
Member Author

Reinmar commented Nov 30, 2020

Can we add a padding at the bottom of the editable in this particular demo? :D

@Reinmar
Copy link
Member Author

Reinmar commented Nov 30, 2020

Or display the tooltip on the left of the button. For all embeds ;)

@niegowski niegowski self-assigned this Nov 30, 2020
@niegowski niegowski mentioned this issue Nov 30, 2020
Merged
@oleq oleq closed this as completed in #8550 Dec 1, 2020
oleq added a commit that referenced this issue Dec 1, 2020
@oleq
Merge pull request #8550 from ckeditor/i/8340
ff62e50 
Fix (html-embed): Tooltips in HTML embeds should not affect the editing root size or scrollbar. Closes #8340.

Feature (ui, theme-lark): Added two new tooltip positions (east and west) in the `TooltipView` class and the `Button` interface (see #8340).

Docs (ckeditor5): The fake selection container should not affect the `:last-child` styling in the editing root (see #8340).

Internal (engine): The fake selection container should have a CSS class for easy styling (see #8340).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 38 (v24.0.0)
Development

Successfully merging a pull request may close this issue.

Tooltips in HTML Embed should not affect editable area size ckeditor/ckeditor5
3 participants
@Reinmar @AnnaTomanek @niegowski