Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips in HTML Embed should not affect editable area size #8550

Merged
merged 6 commits into from
Dec 1, 2020
Merged

Conversation

niegowski
Copy link
Contributor

@niegowski niegowski commented Nov 30, 2020

Suggested merge commit message (convention)

Fix (html-embed): Tooltips in HTML Embed should not affect the editable area size. Closes #8340.

Feature (theme-lark): Added east and west positions for tooltips.

Fix (engine): The fake content selection container should not affect CSS :last-child styling in content (use .ck-content > :not(.ck-fake-selection-container):last-of-type instead).


Additional information

Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it gets a weird horizontal scroll instead :P

Screenshot 2020-12-01 at 11 22 10

@niegowski
Copy link
Contributor Author

Now it gets a weird horizontal scroll instead :P

🤦‍♂️

@niegowski niegowski requested a review from oleq December 1, 2020 10:33
@niegowski
Copy link
Contributor Author

Now it gets a weird horizontal scroll instead :P

Should be OK now 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editable gets a weird extra scroll when it ends with a small HTML embed
3 participants