Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nested blockquotes #9210

Closed
Mgsy opened this issue Mar 11, 2021 · 0 comments · Fixed by #9382
Closed

Add support for nested blockquotes #9210

Mgsy opened this issue Mar 11, 2021 · 0 comments · Fixed by #9382
Assignees
@psmyrek
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 42 (v27...

Comments

@Mgsy
Copy link
Member

Mgsy commented Mar 11, 2021

As CKEditor 4 allows creating nested blockquotes, due to the content compatibility we should make CKEditor 5 retain nested blockquote. Currently intentionally disabled in the schema. Makes content simpler (RTC, versioning, TC).

  • Does it need configuration (opt-in or opt-out)?
  • Where will the configuration be placed? Note: there's an identical scenario in tables – perhaps it should be somehow centralized? But where? 😕

If you'd like to see this feature implemented, add a 👍 reaction to this post.
@Mgsy Mgsy added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). squad:compat domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. labels Mar 11, 2021
@Mgsy Mgsy added this to the nice-to-have milestone Mar 11, 2021
@psmyrek psmyrek modified the milestones: nice-to-have, iteration 42 Mar 26, 2021
@psmyrek psmyrek mentioned this issue Mar 30, 2021
Merged
@AnnaTomanek AnnaTomanek mentioned this issue Mar 31, 2021
Closed
Reinmar added a commit that referenced this issue Apr 7, 2021
@Reinmar
Merge pull request #9382 from ckeditor/i/9210
18de0e2 
Feature (block-quote): Enabled support for nested block quotes. Check out the migration guide for how to disable it again if you do not want to allow nested block quotes Closes #9210.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psmyrek psmyrek

Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 42 (v27.1.0)
Development

Successfully merging a pull request may close this issue.

Enabled support for nested block quotes ckeditor/ckeditor5
2 participants
@Mgsy @psmyrek