Enabled support for nested block quotes #9382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is ready for testing @ckeditor/qa-team. |
|
Looks fine, I didn't find any bugs 👍 |
|
Could you update docs and manual tests in a similar way I did in #9362? |
|
Sure. I've just added a short info in migration guide, a new section in block quote docs how to revert the old behavior and a manual test with the old behavior. |
Reinmar
reviewed
Apr 7, 2021
3 tasks
kesselb
added a commit
to nextcloud/mail
that referenced
this pull request
Sep 6, 2022
1) Move conversion for paragraph to <p style="margin:0;"></p> to plugin 2) Drop schema listener for nested <blockQuote>. Older versions of ckeditor did not support nested blockquotes[^1]. The schema listener is a workaround to keep nested blockquotes[^2]. CKEditor 28 added support for nested blockquotes back[^3][^4]. [^1]: ckeditor/ckeditor5#419 (comment) [^2]: ckeditor/ckeditor5#419 (comment) [^3]: ckeditor/ckeditor5#9382 [^4]: ckeditor/ckeditor5#9472 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
added a commit
to nextcloud/mail
that referenced
this pull request
Sep 6, 2022
1. Move conversion for paragraph to <p style="margin:0;"></p> to plugin 2. Drop schema listener for nested <blockQuote>. Older versions of ckeditor did not support nested blockquotes[^1]. The schema listener is a workaround to keep nested blockquotes[^2]. CKEditor 28 added support for nested blockquotes back[^3][^4]. [^1]: ckeditor/ckeditor5#419 (comment) [^2]: ckeditor/ckeditor5#419 (comment) [^3]: ckeditor/ckeditor5#9382 [^4]: ckeditor/ckeditor5#9472 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
added a commit
to nextcloud/mail
that referenced
this pull request
Sep 6, 2022
1. Move conversion for paragraph to `<p style="margin:0;"></p>` to plugin 2. Drop schema listener for nested `<blockQuote>`. Older versions of ckeditor did not support nested blockquotes[^1]. The schema listener is a workaround to keep nested blockquotes[^2]. CKEditor 28 added support for nested blockquotes back[^3][^4]. [^1]: ckeditor/ckeditor5#419 (comment) [^2]: ckeditor/ckeditor5#419 (comment) [^3]: ckeditor/ckeditor5#9382 [^4]: ckeditor/ckeditor5#9472 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
added a commit
to nextcloud/mail
that referenced
this pull request
Sep 6, 2022
Move conversion for paragraph to `<p style="margin:0;"></p>` to plugin Older versions of ckeditor did not support nested blockquotes[^1]. The schema listener is a workaround to keep nested blockquotes[^2]. CKEditor 28 added support for nested blockquotes back[^3][^4]. [^1]: ckeditor/ckeditor5#419 (comment) [^2]: ckeditor/ckeditor5#419 (comment) [^3]: ckeditor/ckeditor5#9382 [^4]: ckeditor/ckeditor5#9472 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
added a commit
to nextcloud/mail
that referenced
this pull request
Sep 6, 2022
**Add mail plugin** Move conversion for paragraph to `<p style="margin:0;"></p>` to plugin **Drop schema listener for `<blockQuote>`** Older versions of ckeditor did not support nested blockquotes[^1]. The schema listener is a workaround to keep nested blockquotes[^2]. CKEditor 28 added support for nested blockquotes back[^3][^4]. [^1]: ckeditor/ckeditor5#419 (comment) [^2]: ckeditor/ckeditor5#419 (comment) [^3]: ckeditor/ckeditor5#9382 [^4]: ckeditor/ckeditor5#9472 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
added a commit
to nextcloud/mail
that referenced
this pull request
Sep 6, 2022
**Add mail plugin** Move conversion for paragraph to `<p style="margin:0;"></p>` to plugin **Drop schema listener for `<blockQuote>`** Older versions of ckeditor did not support nested blockquotes[^1]. The schema listener is a workaround to keep nested blockquotes[^2]. CKEditor 28 added support for nested blockquotes back[^3][^4]. [^1]: ckeditor/ckeditor5#419 (comment) [^2]: ckeditor/ckeditor5#419 (comment) [^3]: ckeditor/ckeditor5#9382 [^4]: ckeditor/ckeditor5#9472 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
added a commit
to nextcloud/mail
that referenced
this pull request
Sep 7, 2022
**Add mail plugin** Move conversion for paragraph to `<p style="margin:0;"></p>` to plugin **Drop schema listener for `<blockQuote>`** Older versions of ckeditor did not support nested blockquotes[^1]. The schema listener is a workaround to keep nested blockquotes[^2]. CKEditor 28 added support for nested blockquotes back[^3][^4]. [^1]: ckeditor/ckeditor5#419 (comment) [^2]: ckeditor/ckeditor5#419 (comment) [^3]: ckeditor/ckeditor5#9382 [^4]: ckeditor/ckeditor5#9472 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
added a commit
to nextcloud/mail
that referenced
this pull request
Sep 20, 2022
**Add mail plugin** Move conversion for paragraph to `<p style="margin:0;"></p>` to plugin **Drop schema listener for `<blockQuote>`** Older versions of ckeditor did not support nested blockquotes[^1]. The schema listener is a workaround to keep nested blockquotes[^2]. CKEditor 28 added support for nested blockquotes back[^3][^4]. [^1]: ckeditor/ckeditor5#419 (comment) [^2]: ckeditor/ckeditor5#419 (comment) [^3]: ckeditor/ckeditor5#9382 [^4]: ckeditor/ckeditor5#9472 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (block-quote): Enabled support for nested block quotes. Closes #9210.
Additional information
Support for nested block quotes in CF has a dedicated follow-up: https://github.com/cksource/collaboration-features/issues/3892.
After a brief check, I wasn't able to blow up the editor in CF samples.