Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image support to the text editor: Move CKEditor schema/conversion from onEditorReady to plugin #7141

Closed
kesselb opened this issue Sep 2, 2022 · 0 comments · Fixed by #7195
Closed

Add image support to the text editor: Move CKEditor schema/conversion from onEditorReady to plugin #7141

kesselb opened this issue Sep 2, 2022 · 0 comments · Fixed by #7195
Assignees
@kesselb
Labels
1. to develop enhancement technical debt
Milestone
v2.0.0

Comments

@kesselb
Copy link
Contributor

kesselb commented Sep 2, 2022

Is your feature request related to a problem? Please describe.

Follow up #6935

onEditorReady = the editor is initialized and the initial data already loaded.

Describe the solution you'd like

Move schema/conversion to a new plugin.
Add tests for it.

Describe alternatives you've considered

No response

Additional context

No response
@kesselb kesselb added this to the v2.0.0 milestone Sep 2, 2022
@kesselb kesselb self-assigned this Sep 2, 2022
@ChristophWurst ChristophWurst moved this to 📄 To do (~10 entries) in 💌 📅 👥 Groupware team Sep 5, 2022
kesselb added a commit that referenced this issue Sep 6, 2022
@kesselb
GH-7141: Add ckeditor plugin for mail
c58b587 
- Move conversion for paragraph to <p style="margin:0;"></p> to plugin

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit that referenced this issue Sep 6, 2022
@kesselb
GH-7141: Add ckeditor plugin for mail
b779572 
1) Move conversion for paragraph to <p style="margin:0;"></p> to plugin

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit that referenced this issue Sep 6, 2022
@kesselb
GH-7141: Add ckeditor plugin for mail
3a07901 
1) Move conversion for paragraph to <p style="margin:0;"></p> to plugin

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit that referenced this issue Sep 6, 2022
@kesselb
GH-7141: Add ckeditor plugin for mail
2adc96a 
1)

Move conversion for paragraph to <p style="margin:0;"></p> to plugin

2) Drop schema listener for nested <blockQuote>.

Older versions of ckeditor did not support nested blockquotes[^1].
The schema listener is a workaround to keep nested blockquotes[^2].
CKEditor 28 added support for nested blockquotes back[^3][^4].

[^1]: ckeditor/ckeditor5#419 (comment)
[^2]: ckeditor/ckeditor5#419 (comment)
[^3]: ckeditor/ckeditor5#9382
[^4]: ckeditor/ckeditor5#9472

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit that referenced this issue Sep 6, 2022
@kesselb
GH-7141: Add ckeditor plugin for mail
9a61b94 
1.

Move conversion for paragraph to <p style="margin:0;"></p> to plugin

2.

Drop schema listener for nested <blockQuote>.

Older versions of ckeditor did not support nested blockquotes[^1].
The schema listener is a workaround to keep nested blockquotes[^2].
CKEditor 28 added support for nested blockquotes back[^3][^4].

[^1]: ckeditor/ckeditor5#419 (comment)
[^2]: ckeditor/ckeditor5#419 (comment)
[^3]: ckeditor/ckeditor5#9382
[^4]: ckeditor/ckeditor5#9472

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit that referenced this issue Sep 6, 2022
@kesselb
GH-7141: Add ckeditor plugin for mail
324255d 
1. Move conversion for paragraph to `<p style="margin:0;"></p>` to plugin

2. Drop schema listener for nested `<blockQuote>`.

Older versions of ckeditor did not support nested blockquotes[^1].
The schema listener is a workaround to keep nested blockquotes[^2].
CKEditor 28 added support for nested blockquotes back[^3][^4].

[^1]: ckeditor/ckeditor5#419 (comment)
[^2]: ckeditor/ckeditor5#419 (comment)
[^3]: ckeditor/ckeditor5#9382
[^4]: ckeditor/ckeditor5#9472

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit that referenced this issue Sep 6, 2022
@kesselb
GH-7141: Add ckeditor plugin for mail
d744e88 
Move conversion for paragraph to `<p style="margin:0;"></p>` to plugin

Older versions of ckeditor did not support nested blockquotes[^1].
The schema listener is a workaround to keep nested blockquotes[^2].
CKEditor 28 added support for nested blockquotes back[^3][^4].

[^1]: ckeditor/ckeditor5#419 (comment)
[^2]: ckeditor/ckeditor5#419 (comment)
[^3]: ckeditor/ckeditor5#9382
[^4]: ckeditor/ckeditor5#9472

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit that referenced this issue Sep 6, 2022
@kesselb
GH-7141: Add ckeditor plugin for mail
8c3a4ee 
**Add mail plugin**

Move conversion for paragraph to `<p style="margin:0;"></p>` to plugin

**Drop schema listener for `<blockQuote>`**

Older versions of ckeditor did not support nested blockquotes[^1].
The schema listener is a workaround to keep nested blockquotes[^2].
CKEditor 28 added support for nested blockquotes back[^3][^4].

[^1]: ckeditor/ckeditor5#419 (comment)
[^2]: ckeditor/ckeditor5#419 (comment)
[^3]: ckeditor/ckeditor5#9382
[^4]: ckeditor/ckeditor5#9472

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit that referenced this issue Sep 6, 2022
@kesselb
GH-7141: Add ckeditor plugin for mail
d02a06e 
**Add mail plugin**

Move conversion for paragraph to `<p style="margin:0;"></p>` to plugin

**Drop schema listener for `<blockQuote>`**

Older versions of ckeditor did not support nested blockquotes[^1].
The schema listener is a workaround to keep nested blockquotes[^2].
CKEditor 28 added support for nested blockquotes back[^3][^4].

[^1]: ckeditor/ckeditor5#419 (comment)
[^2]: ckeditor/ckeditor5#419 (comment)
[^3]: ckeditor/ckeditor5#9382
[^4]: ckeditor/ckeditor5#9472

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit that referenced this issue Sep 7, 2022
@kesselb
GH-7141: Add ckeditor plugin for mail
75afe07 
**Add mail plugin**

Move conversion for paragraph to `<p style="margin:0;"></p>` to plugin

**Drop schema listener for `<blockQuote>`**

Older versions of ckeditor did not support nested blockquotes[^1].
The schema listener is a workaround to keep nested blockquotes[^2].
CKEditor 28 added support for nested blockquotes back[^3][^4].

[^1]: ckeditor/ckeditor5#419 (comment)
[^2]: ckeditor/ckeditor5#419 (comment)
[^3]: ckeditor/ckeditor5#9382
[^4]: ckeditor/ckeditor5#9472

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit that referenced this issue Sep 20, 2022
@kesselb
GH-7141: Add ckeditor plugin for mail
64d29b0 
**Add mail plugin**

Move conversion for paragraph to `<p style="margin:0;"></p>` to plugin

**Drop schema listener for `<blockQuote>`**

Older versions of ckeditor did not support nested blockquotes[^1].
The schema listener is a workaround to keep nested blockquotes[^2].
CKEditor 28 added support for nested blockquotes back[^3][^4].

[^1]: ckeditor/ckeditor5#419 (comment)
[^2]: ckeditor/ckeditor5#419 (comment)
[^3]: ckeditor/ckeditor5#9382
[^4]: ckeditor/ckeditor5#9472

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb mentioned this issue Sep 20, 2022
Merged
ChristophWurst added a commit that referenced this issue Sep 20, 2022
@ChristophWurst
Merge pull request #7195 from nextcloud/enh/7141/ckeditor-schema-to-p…
c39d48e 
…lugin

GH-7141: Add ckeditor plugin for mail
Repository owner moved this from 📄 To do (~10 entries) to ☑️ Done in 💌 📅 👥 Groupware team Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kesselb kesselb

Labels
1. to develop enhancement technical debt
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

GH-7141: Add ckeditor plugin for mail nextcloud/mail
1 participant
@kesselb