Add support for screen reader announcements in code block document elements. #16056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
requested changes
Mar 20, 2024
Comment on lines
+285
to
+289
| if ( direction === 'enter' ) { | ||
| return t( 'Entering code snippet' ); | ||
| } | ||
|
|
||
| return t( 'Leaving code snippet' ); |
There was a problem hiding this comment.
I think we can safely assume there will never be a code snippet without the language upcasted in the editor. See
ckeditor5/packages/ckeditor5-code-block/src/converters.ts
Lines 205 to 207 in 84d1ada
element.getAttribute( 'language' )!.
There was a problem hiding this comment.
It can happen if language passed to codeBlock has no language definition specified in config (like FooBar). I'd stay with a bit more verbose but safer approach.
Mati365
changed the title
aria-label attributes to code-block document element.
Mati365
changed the title
|
@oleq Can you take a look again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (code-block): Introduced screen reader announcements for entering or exiting code block elements in the document editor. Closes #16053.