Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for screen reader announcements in code block document elements. #16056
Add support for screen reader announcements in code block document elements. #16056
Changes from 6 commits
80a45b5
1a56b5c
e3c6e63
af222f2
eb69e60
f34cdb4
84d1ada
dbcde9a
6acc850
0f875e3
9115377
d8b3b66
fc4db87
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can safely assume there will never be a code snippet without the language upcasted in the editor. See
ckeditor5/packages/ckeditor5-code-block/src/converters.ts
Lines 205 to 207 in 84d1ada
element.getAttribute( 'language' )!
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can happen if
language
passed tocodeBlock
has no language definition specified in config (likeFooBar
). I'd stay with a bit more verbose but safer approach.