Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed and replaced usage: mgit => mrgit #1819

Merged
merged 3 commits into from
Jul 23, 2019
Merged

Renamed and replaced usage: mgit => mrgit #1819

merged 3 commits into from
Jul 23, 2019

Conversation

pomek
Copy link
Member

@pomek pomek commented Jun 17, 2019

Suggested merge commit message (convention)

Other: Adjusted repository, documentation and scripts to changes done in mgit/mrgit. See: cksource/mrgit#85.


Additional information

  1. Requires: Rename package: mgit2 => mrgit cksource/mrgit#106 and published package as mrgit (should it be version 1.0.0?).
  2. Requires reinstall dependencies in yarn.lock (I'd remove yarn.lock then yarn install)

IMO – this change is a BC for this repository. Even if someone won't update mrgit, the mgit.json file has been renamed to mrgit.json which mgit cannot understand. As a workaround, people can create a symlink ls -s mrgit.json mgit.json and it should work.

@pomek pomek requested a review from Reinmar June 17, 2019 11:58
@pomek pomek marked this pull request as ready for review July 23, 2019 10:16
@@ -18,12 +18,12 @@ if ( !branchName ) {
const path = require( 'path' );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to rename this file…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem. We're removing it very soon.

@Reinmar Reinmar merged commit f19fb8d into master Jul 23, 2019
@Reinmar Reinmar deleted the t/mgit2/85 branch July 23, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants