Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink name of this package #85

Closed
jodator opened this issue Oct 11, 2018 · 16 comments · Fixed by #106
Closed

Rethink name of this package #85

jodator opened this issue Oct 11, 2018 · 16 comments · Fixed by #106

Comments

@jodator
Copy link
Contributor

jodator commented Oct 11, 2018

We're using mgit2 as a name of a package as we forked the mgit tool. The name of this tool is a bit unfortunate so we might think how to name it (besides mgit3).

My propositions:

  • ogit as owesome (dead joke) git
  • pgit as pararel git
  • mrgit as multi-repo git
  • tigm (as tig is already reserved)
  • kgit similiary typed as mgit
@oleq
Copy link
Member

oleq commented Oct 11, 2018

To me, it does not matter as long as it is fast to type because this is something I'll type many times each day. ogit and pgitfeel like the most convenient to type for me e.g. unlike tigm.

@jodator
Copy link
Contributor Author

jodator commented Oct 11, 2018

@oleq That's why I've researched free npm terms and those are free & fast to write (first letter on the right side of keyboard): ogit, pgit, kgit. With kgit being the most "ergonomic" to type...

@Reinmar Reinmar added this to the next milestone Jan 11, 2019
@neumann-d
Copy link
Contributor

I would suggest a more fancy name like repomonkey (just a stupid example), which is longer, but maybe more catchy for the users.

@Reinmar
Copy link
Member

Reinmar commented May 20, 2019

Just a reminder that we need to change this name finally :D ckeditor/ckeditor5#330 (comment)

@Reinmar
Copy link
Member

Reinmar commented May 20, 2019

The problem with a longer name is that we'd need to type it all the time. Unless there's some shorthand for that. So, e.g. for repomonkey it could be rpm, but rpm is unfortunately already taken (and the package name should be the same as the command name, as we've just learned). BTW, rpm is funny because running it will increase your CPU's rpm 🤪

From the proposals that I liked (let's hope no one will troll us and reserve those names):

  • mrgit (reads as "mr. git")
  • mugit (from multi-git – extensions of today's mgit)

I think both are easy to type (although, mugit better than mrgit for me) and sound well too. WDYT?

@pomek
Copy link
Member

pomek commented May 20, 2019

TBH, I don't see any problem with mgit name.

@Reinmar
Copy link
Member

Reinmar commented May 20, 2019

TBH, I don't see any problem with mgit name.

What about the actual problem that a community had with it? See the link I posted above.

@jodator
Copy link
Contributor Author

jodator commented May 20, 2019

👍 mrgit

@pjasiun
Copy link

pjasiun commented May 20, 2019

👍 for Mr git.

@mlewand
Copy link
Contributor

mlewand commented May 20, 2019

I like mrgit. The name make sense for this app. I'm not concerned about the length, I'm using already mg alias for mgit, coz mgit is already too long 😂

@pomek
Copy link
Member

pomek commented May 20, 2019

@Reinmar, as I could see, this guy just wasn't aware that he needs to install more tools. He could miss it in docs or forget to install. Changing the name won't resolve the problem.

@jodator
Copy link
Contributor Author

jodator commented May 20, 2019

Changing the name won't resolve the problem.

Will resolve a problem of:

  • wrong package installed: mgit vs mgit2
  • wrong package used by npx command (non-initialised repo): npx mgit sync vs npx mgit2 sync.

@ma2ciek
Copy link
Contributor

ma2ciek commented May 20, 2019

☝️ Yes, I have to agree with @jodator, For example, I've installed many times the ncu (ncu-weather-cli) instead of npm-check-dependencies. Both of them provide the ncu command. This is also a security issue.

@pomek
Copy link
Member

pomek commented May 20, 2019

Not related to the entire topic but an argument that you installed something different than you expected is not valid. Before calling npm i whatever, would be good to see what the whatever is. (https://www.npmjs.com/package/ncu explains everything in that case). This is a security check.

I don't want to block the issue. Just type the final proposition and I am going to rename the package.

@ma2ciek
Copy link
Contributor

ma2ciek commented May 20, 2019

Not related to the entire topic but an argument that you installed something different than you expected is not valid. Before calling npm i whatever, would be good to see what the whatever is.

I did it installing the npm-check-dependencies for the first time. But later I only remembered the ncu because of the CLI tool and I was expecting this package to be available on the NPM.

@Reinmar
Copy link
Member

Reinmar commented May 22, 2019

OK, mrgit it is. Let's do it :)

Reinmar added a commit that referenced this issue Jul 23, 2019
Other: RIP mgit2 💀 Long live mrgit 🎉 Closes #85.

BREAKING CHANGE: mgit2 was renamed to mrgit.
@pomek pomek self-assigned this Jul 23, 2019
Reinmar added a commit to ckeditor/ckeditor5-dev that referenced this issue Jul 23, 2019
Other: Adjusted repository, documentation and scripts to changes done in mgit/mrgit. See: cksource/mrgit#85.
@mlewand mlewand modified the milestones: next, iteration 26 Jul 23, 2019
Reinmar added a commit to ckeditor/ckeditor5 that referenced this issue Jul 23, 2019
Other: Adjusted repository, documentation and scripts to changes done in mgit/mrgit. See: cksource/mrgit#85.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants