-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shorthand focus()
method in generic Editor
class
#8346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the CI fails with:
WARN: 'Detected `console.warn()`:', 'There is no selection in any editable to focus.'
Chrome 86.0.4240.111 (Linux x86_64) Editor focus() should call view's focus() method FAILED
Error: Detected `console.warn()`:
at console.<computed> [as warn] (webpack:///./build/.automated-tests/entry-point.js?:40:11)
at View.focus (webpack:///./packages/ckeditor5-engine/src/view/view.js?:438:33)
at Function.invoke (node_modules/sinon/pkg/sinon.js:1922:47)
at View.focus (node_modules/sinon/pkg/sinon.js:2178:26)
at TestEditor.focus (webpack:///./packages/ckeditor5-core/src/editor/editor.js?:19:4566)
at Context.eval (webpack:///./packages/ckeditor5-core/tests/editor/editor.js?:577:11)
https://travis-ci.org/github/ckeditor/ckeditor5/builds/738967351
CI build has been fixed by explicitly setting |
It's not needed to put implementation details in the method docs.
LGTM, just one last thing that we should do in this PR is to replace existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the context of remaining changes.
packages/ckeditor5-ui/docs/framework/guides/deep-dive/focus-tracking.md
Outdated
Show resolved
Hide resolved
packages/ckeditor5-ui/docs/framework/guides/deep-dive/focus-tracking.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor adjustment in one guide.
Suggested merge commit message (convention)
Feature (core): Introduced the
focus()
method in the baseEditor
class. Closes #714.Additional information
The
editor.focus()
method is just a shorthand foreditor.editing.view.focus()
.