-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement editor.focus()
#714
Comments
Btw, when it comes to the behavior, |
We have the Still, I'd consider implementing WDYT? cc @oleq @oskarwrobel @pjasiun |
As a clarification, please notice the semantic difference:
|
I agree. PS. Buttons should still call |
Agree. That's not clear at all what to do to focus editor. |
|
As pointed in #714 (comment) the changes in our UI buttons should be reverted. I'll add a PR with a revert for this. |
Revert: Reverted widespread `editor.focus()` usage back to `editor.editing.view.focus()` form. Closes #714.
I have an CKEditor instance in a grid wich when editing a cell popus up the editor, but for some odd reason focus event doesn't work. If I move it out from the grid it works perfectly. Any input? |
@julian-henao please create a new issue with the full description, thanks! |
π Is this a bug report or feature request? (choose one)
β Expected result
For implementors, I think a common requirement is moving the focus to the editor either on startup or when doing actions outside of it. I was facing this need.
My first approach for it was trying to use the main API entrypoint for it, the editor instance, and call
editor.focus()
. This is not available.β Actual result
Currently, I'm using the following:
editor.element.focus()
, which touches the native web API. I assume this worked just because I'm using the ballon editor and my original div is there. I would be even more confused if I would have to do it with other creators that replace my element.The text was updated successfully, but these errors were encountered: