Reply issues

[jancborchardt]

When you reply to an email, there are some small issues which are quite annoying when summed up:

• The "To" field is focused, even though the recipient is already filled
• You are prefilled in the "cc" field and need to manually remove yourself
• The text body has no space above and you need to insert newlines yourself. Expected would be focus on the first line, and 2 empty lines below until the original message.
• If you are replying from the unified inbox, the wrong account is selected. This might be related to yourself being prefilled in cc → separated out into Replying from the unified inbox, the wrong account is selected #2428

cc @nextcloud/mail I’d say this is some crucial polishing for 18.

[StCyr]

point "You are prefilled in the "cc" field and need to manually remove yourself" is to be resolved by #2454

[ChristophWurst]

Yep, could also be a side effect of #2447 as the reply recipient logic depends on the account used.

[StCyr]

Regarding the 2 last points ('The "To" field is focused, even though the recipient is already filled' and 'The text body has no space above and you need to insert newlines yourself. Expected would be focus on the first line, and 2 empty lines below until the original message.'),

It's easy to not set the focus on the 'To' field when it's already filled but it's more difficult to set the focus on the body: It seems ckeditor5 doesn't support the startupFocus config parameter anymore :(

See https://ckeditor.com/docs/ckeditor5/latest/api/index.html and https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_config.html#cfg-startupFocus

[ChristophWurst]

The "To" field is focused, even though the recipient is already filled

@GretaD you can use ckeditor/ckeditor5#714 (comment) at

mail/src/components/TextEditor.vue

Lines 111 to 136 in b2cce62

	onEditorReady(editor) {
	const schema = editor.model.schema
	schema.on(
	'checkChild',
	(evt, args) => {
	const context = args[0]
	if (context.endsWith('blockQuote')) {
	// Prevent next listeners from being called.
	evt.stop()
	// Set the checkChild()'s return value.
	evt.return = true
	}
	},
	{
	priority: 'highest',
	}
	)
	// Set value as late as possible, so the custom schema listener is used
	// for the initial editor model
	this.text = this.value
	logger.debug(`setting TextEditor contents to <${this.text}>`)
	},

with an if only for replies ;)

[GretaD]

i can and i did :)

[jancborchardt]

Very nice! :) Can we also fix the issue of not having extra empty lines on the top when you reply? 🎈