Focus editor in replies and forwdared messagess #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at> Signed-off-by: GretaD <gretadoci@gmail.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
reply_issues
branch
from
e78e4f8 to
5c13c5f
Compare
ChristophWurst
changed the title
ChristophWurst
approved these changes
Jan 14, 2020
ChristophWurst
changed the title
| @@ -127,6 +131,9 @@ export default { | |||
| priority: 'highest', | |||
| } | |||
| ) | |||
| if (this.focus) { | |||
| logger.debug('focusing TextEditor') | |||
There was a problem hiding this comment.
This should probably be removed? :)
There was a problem hiding this comment.
I'm fine with leaving those as they aid debugging of bug reports.
|
Hmm, I can’t really confirm that it fixes anything? Also I still have myself in cc when replying to mails. |
|
Have you built the app? What happens when you try to reply to a message? What is focused? Do you see the debug log about the focus? |
ChristophWurst
force-pushed
the
reply_issues
branch
2 times, most recently
from
4a21fb3 to
3d97d83
Compare
|
@jancborchardt its working now, can you please recheck? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2373