Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table caption feature #9242

Merged
merged 76 commits into from
May 7, 2021
Merged

Table caption feature #9242

merged 76 commits into from
May 7, 2021

Conversation

niegowski
Copy link
Contributor

@niegowski niegowski commented Mar 15, 2021

Suggested merge commit message (convention)

Feature (table): Added support for captions (figure > figcaption + table and table > caption). Closes #3204.

...


Additional information

This is a feature branch for aggregating partial PRs.

@Reinmar Reinmar added this to the iteration 42 milestone Mar 19, 2021
maxbarnas and others added 25 commits April 20, 2021 12:18
Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
Feature (table): Table operations work now with table caption. Closes #9105 .
Feature (table): Added toolbar buttons for table captions. Closes #9104. Closes #9086. Closes #9304. Closes #9087. Closes #9088. Closes #9085.
Docs (table): Added caption documentation and demo. Closes #9085.
Fix (table): The table should not save the caption in the model attribute to prevent issues in collaboration. Closes #9543.
@FilipTokarski
Copy link
Member

I did some testing today and it looks ok, works also with CF 👍

@maxbarnas maxbarnas marked this pull request as ready for review May 6, 2021 14:37
@niegowski niegowski merged commit b542721 into master May 7, 2021
@niegowski niegowski deleted the i/3204-table-caption branch May 7, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement table captions
7 participants