Allow nesting of '--' #1162
Merged
Allow nesting of '--' #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppose there is a program that executes another program, then it is convenient to take the arguments of the subprogram after `--`, as illustrated in the 22_stop_parsing_with_--.rs example. However, if the subprogram itself wants to receive `--`, then clap-rs should allow it. Fixes clap-rs#1161.
|
Wow, fast! Thanks for going ahead and knocking this out! Once the tests pass I'll merge. There a few other minor issues I'll knock out shortly then put out v2.29.3 👍 |
willmurphyscode
added a commit
to willmurphyscode/clap-rs
that referenced
this pull request
Mar 1, 2018
Copy the fix from clap-rs#1162 into the v3 parser, and add a test to protect against regressions in the expected behavior of example 22.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose there is a program that executes another program, then it is convenient to take the arguments of the subprogram after
--, as illustrated in the22_stop_parsing_with_--.rsexample. However, if the subprogram itself wants to receive--, then clap-rs should allow it.Fixes #1161.
This change is