Port 1161 fix to v3 #1198
Merged
Port 1161 fix to v3 #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the fix from clap-rs#1162 into the v3 parser, and add a test to protect against regressions in the expected behavior of example 22.
|
@willmurphyscode, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer. |
|
@willmurphyscode to reproduce the failure compile with |
This adds a keys method to the internal implementation of vec_map and adds conditional compilation in the parser to make the parser compile with or without the vec_map dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the fix from #1162 into
the v3 parser, and add a test to protect against regressions in the
expected behavior of example 22.
Note: I haven't been able to lint this -
cargo build --features lintsseems to fail on current nightly. I assume CI will tell me if I messed up linting, but I wanted to mention it.This change is