fix(parser): Improve args_conflicts_with_subcommands experience
#5298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
added a commit
to epage/clap
that referenced
this pull request
Jan 15, 2024
With clap-rs#5298, I had overlooked that `matcher.arg_ids()` includes `ArgGroup`s. I had assumed I could always find a present `id` among `Arg`s and `unwrap`ed. I skipped a test for this because the use case is a bit strange that the long term value for the test would likely be low. If/when we add derive support for `args_conflicts_with_subcommands`, it will then cover this case. Fixes clap-rs#5304
remi-delmas-3000
pushed a commit
to remi-delmas-3000/kani
that referenced
this pull request
Jan 18, 2024
Starting from clap v4.4.15 clap-rs/clap#5298 UnknownArgument errors are reported as ArgumentConflict errors.
celinval
pushed a commit
to model-checking/kani
that referenced
this pull request
Jan 19, 2024
Starting from clap v4.4.15 clap-rs/clap#5298 in some cases `UnknownArgument` errors are reported as `ArgumentConflict` errors. Co-authored-by: Remi Delmas <delmasrd@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error was bad and there were holes from adding subcommand flags
Fixes #5297