fix(parser): Don't panic with conflicts and groups #5306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #5298, I had overlooked that
matcher.arg_ids()
includesArgGroup
s. I had assumed I could always find a presentid
amongArg
s andunwrap
ed.I skipped a test for this because the use case is a bit strange that the long term value for the test would likely be low.
If/when we add derive support for
args_conflicts_with_subcommands
, it will then cover this case.Fixes #5304