[FEATURE] Add cosmwasm-std message for community pool

[lunc808]

We are requesting to add the cosmwasm-std crate so we can implement the necessary bindings into our smart contracts.

Edit by @fragwuerdig

When I understand it correctly you want us to add MsgFundCommunityPool to the wasm bindings so you can use it in smart contracts. Which is an excellent idea imho.

• Evaluate whether this can be added to wasmd interface or inside core as terra custom binding
• Add wasm binding for MsgFundCommunityPool from the distribution module accordingly
• Update either CosmWasm::std crate (would need upstream push) or terra-bindings repository accordingly.
• Write some rust example contract on how to use it

[inon-man]

It's compatible with the official wasmvm v1.1.2 and cosmwasm v1.2. However, MsgFundCommunityPool has to be added to wasmvm and cosmwasm

[fragwuerdig]

@inon-man: I wonder If it would makes sense to add it into the terra-bindings and provide it as custom msg. This way we won't need to push it upstream - which probably takes ages to get merged and available for dApp builders on classic?

[inon-man]

@inon-man: I wonder If it would makes sense to add it into the terra-bindings and provide it as custom msg. This way we won't need to push it upstream - which probably takes ages to get merged and available for dApp builders on classic?

I think it is possible and probably the best way to go.

[fragwuerdig]

@inon-man: I wonder If it would makes sense to add it into the terra-bindings and provide it as custom msg. This way we won't need to push it upstream - which probably takes ages to get merged and available for dApp builders on classic?

I think it is possible and probably the best way to go.

Ok. I will try to push it upstream in parallel.

[webmaster128]

Hi! Happy to add this upstream. In the meantime also note this Anybuf implementation as a workaround for contract devs:

• https://github.com/noislabs/nois-contracts/blob/v0.13.6/contracts/nois-payment/src/contract.rs#L112-L118
• https://github.com/noislabs/nois-contracts/blob/v0.13.6/contracts/nois-payment/src/contract.rs#L128-L138

[fragwuerdig]

Hey. Just for the sake of completeness I am adding all the PRs for this feature in this list:

• Add MsgFundCommunityPool to the Distribution Msgs CosmWasm/wasmvm#433
• Add FundCommunityPool to supported Distribution Msgs CosmWasm/cosmwasm#1747
• Add Encodings For MsgFundCommunityPool from Distribution CosmWasm/wasmd#1458

We can backport these features into our downstream repos so they can be used by contract owners as git dependency in their corresponding Cargo.toml. @inon-man: Is adding the FundCommunityPoolMsg to wasmd consensus breaking? I feel like it is.

[inon-man]

Hey. Just for the sake of completeness I am adding all the PRs for this feature in this list:

• Add MsgFundCommunityPool to the Distribution Msgs CosmWasm/wasmvm#433
• Add FundCommunityPool to supported Distribution Msgs CosmWasm/cosmwasm#1747
• Add Encodings For MsgFundCommunityPool from Distribution CosmWasm/wasmd#1458

We can backport these features into our downstream repos so they can be used by contract owners as git dependency in their corresponding Cargo.toml. @inon-man: Is adding the FundCommunityPoolMsg to wasmd consensus breaking? I feel like it is.

I don't think it would break the consensus? Where do you feel it so from?

[fragwuerdig]

@inon-man: I was thinking: A validator that accepts the message from the mempool and deserializes it correctly will pass it on to be further processed. A validator that not matches against the new DistributionMsg variant would fail to process it. So state for both validators would end up being different. Thus I was believing it breaks consensus...

[inon-man]

It is just a binding for the msg already supported by Cosmos SDK. Imagine that there was no MsgSend in cosmwasm.

@fragwuerdig I think you are right. It's a state breaking change.

[nghuyenthevinh2000]

@inon-man does this one needs a migration logic in upgrade?

[nghuyenthevinh2000]

@fragwuerdig do you have an example contract on this?

[fragwuerdig]

@nghuyenthevinh2000: I can certainly make one... One that sends its own balance to CP using a permissionless trigger msg. Make an issue and assign me if you like.

[nghuyenthevinh2000]

@nghuyenthevinh2000: I can certainly make one... One that sends its own balance to CP using a permissionless trigger msg. Make an issue and assign me if you like.

you can find it here: #326