Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FundCommunityPool to supported Distribution Msgs #1747

Closed
wants to merge 3 commits into from

Conversation

fragwuerdig
Copy link
Contributor

@fragwuerdig fragwuerdig commented Jun 23, 2023

Hello. I politely ask to add FundCommunityPool msg to cosmwasm::std, because it is a "hot" feature for Terra Classic smart contract owners. This PR is a third follow-up in a series of follow-ups described by the following issues and PRs:

The changes include:

  • add FundCommunityPool to the list of supported/serializable DistributionMsgs
  • add serialization test
  • add serialization test for the other DistributionMsg variants (for the sake of completeness)

Note that this would likely need to be merged after the above mentioned PRs have been accepted. Thank you for considering this. We appreciate your support.

@webmaster128

This comment was marked as resolved.

@mergify

This comment was marked as resolved.

@webmaster128 webmaster128 self-assigned this Jun 26, 2023
@webmaster128 webmaster128 changed the base branch from main to release/1.3 June 26, 2023 07:35
@webmaster128

This comment was marked as resolved.

@mergify

This comment was marked as resolved.

@webmaster128 webmaster128 changed the base branch from release/1.3 to main June 26, 2023 07:36
@webmaster128
Copy link
Member

@Mergifyio backport release/1.3

@mergify
Copy link
Contributor

mergify bot commented Jun 26, 2023

backport release/1.3

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM. Just the feature gate and could you add an entry to the UNREASED section of CHANGELOG.md?

packages/std/src/results/cosmos_msg.rs Show resolved Hide resolved
fragwuerdig and others added 2 commits June 28, 2023 01:56
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@fragwuerdig
Copy link
Contributor Author

Ok. Done. Thank you.

@webmaster128
Copy link
Member

Thank you! I'll get this on the 1.3 release right after #1593 is merged.

@webmaster128
Copy link
Member

Merged in #1752. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants