Add Encodings For MsgFundCommunityPool from Distribution
#1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpe
reviewed
Jun 23, 2023
There was a problem hiding this comment.
Very nice work. Thanks for the PR and test! 🥇
I will approve it once CosmWasm/wasmvm#433 is merged and released. No changes required
This was referenced Jun 23, 2023
|
Linking #1296 to unblock this |
|
@Mergifyio rebase |
❌ Pull request can't be updated with latest base branch changesMergify needs the author permission to update the base branch of the pull request. |
Closed
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
* add FundCommunityPoolMsg to DistributionMsgs * gofumpt (cherry picked from commit c23ecae)
alpe
added a commit
that referenced
this pull request
Jul 18, 2023
Add Encodings For `MsgFundCommunityPool` from Distribution (backport #1458)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. This is a follow-up for the follwoing issues and PRs:
MsgFundCommunityPoolto the Distribution Msgs wasmvm#433This PR conducts following changes:
MsgFundCommunityPoolto the supported Msg encodingsDepositorfield is automatically filled with sender address (= contract)Note that this PR depends on changes in wasmvm repository. I ran the build and unit-tests locally where I could easily swap the wasmvm dependency with my local wasmvm repo using replace section in
go.mod. So before merging a version bump of wasmvm might be required.