-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does this work with React 0.11.1? #26
Comments
Hm, I ran our tests against React 0.11 and they pass Did you try running your project against React 0.10 to verify that 0.11 causes the issue? There were also some breaking changes in that release, which might also be affecting your project |
Right, thanks, Clay. I previously looked at breaking changes and didn’t see any obvious culprits. I am trying the most basic usage of React.Bacebone possible. I am starting from the coffee-react-quickstart project, however. Anyway, if you feel generous, check out this branch (then run |
If I try React.createBackboneClass, the error message is as follows:
|
Hey, you know what, it looks like it has to do with the hotloader that comes with the quickstart. |
Thoughts on how to resolve this are welcome |
But it’s clear at this point the bug does not lie with react.backbone |
Update: the hotloader does not seem to be to blame, after all. See this update |
Think there may be some sort of require-order issue here? |
See also: remix-run/react-router#146 |
In that issue it's suggested the dependencies aren't specified the right way. Personally, I use this plugin via bower, using the rails asset pipeline. If any of the other dependency management systems is having a problem, I'd be happy to merge a pull-request, but I can't test/verify these errors myself (and given the order of pr's, I suspect @clayallsopp isn't using AMD/... either). Imo it's really sad how this problem is currently solved in JS-land, you have to support multiple systems, but of course you're not using them (all) yourself. I would be very happy if at some point we get one system everyone uses :) |
There's a "help everyone converge on NPM" movement. In this case, it looks like a rough edge of NPM: your package specifies You should (probably) move |
I've attempted to make the change in 209cb8d - can someone try that out? (ie use |
Thanks, @clayallsopp! That absolutely has solved the problem! Big thanks for pointing out the exact problem and solution, @gaearon! |
No problem, just found the same problem with Underscore in my project, unnoticed for weeks. :-) |
Maybe Webpack can start warning about this |
Filed as webpack/webpack#385 if you'd like to chime in. |
To avoid conflicts with client react version - see clayallsopp/react.backbone#26
To avoid conflicts with client react version - see clayallsopp/react.backbone#26
I had some issues trying to use this with React 0.11.1, but I’m not sure if the problem was me or a version mismatch.
mountComponent
is complaining it can't findthis.props
when I usecreateBackboneClass
. (Note also thatReact.createBackboneClass
no longer seems to be defined; I had to importreact.backbone
asRB
and then callRB.createBackboneClass
.The text was updated successfully, but these errors were encountered: