Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use peerDependencies #2

Merged
merged 1 commit into from
Jan 14, 2015
Merged

Use peerDependencies #2

merged 1 commit into from
Jan 14, 2015

Conversation

eldh
Copy link
Contributor

@eldh eldh commented Jan 7, 2015

Use peerDependencies to avoid react being loaded twice (as adviced here: clayallsopp/react.backbone#26 (comment)). Fucked up the commit history a bit but it should be fine I think...

@kalasjocke
Copy link
Owner

@eldh Interesting, makes sense to use peerDependencies to specify the React version since this is fact a plugin. However, the build fails on Travis, do you have any clever ideas on how to make this work? Also, could you just rebase and squash all your commits into one and force push that one to this branch? We would get a lot cleaner history then.

@eldh
Copy link
Contributor Author

eldh commented Jan 11, 2015

I think the way react-router does it makes sense, although it's a bit weird to define the dependency twice: https://github.com/rackt/react-router/blob/master/package.json. Peer dependency for production and dev dependency for running tests.

@kalasjocke
Copy link
Owner

I think so to! Thanks for this pull request @eldh! 🍰

kalasjocke added a commit that referenced this pull request Jan 14, 2015
@kalasjocke kalasjocke merged commit eb3939f into kalasjocke:master Jan 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants