Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Use correct install snippet in snapshot comment #1901

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

LekoArts
Copy link
Member

Description

In our snapshot comment we were missing the --save-exact flag. With our current snippets you installed it with a ^ caret, making it possible for another version to be installed.

I also moved the name out of the code block so that when you copy it to your terminal the comment is not also copied.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@LekoArts LekoArts requested a review from a team as a code owner October 17, 2023 12:25
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

⚠️ No Changeset found

Latest commit: 2f906ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dimkl
Copy link
Contributor

dimkl commented Oct 17, 2023

@LekoArts i think we have dropped the carets from our package.json for the internal dependencies: #1798

@LekoArts
Copy link
Member Author

This is for the installation inside the test project. You'll want to install the exact version, not the caret version - otherwise you might install another snapshot

Copy link
Member

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense to me

@BRKalow BRKalow added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit c8dfc3b Oct 17, 2023
12 checks passed
@BRKalow BRKalow deleted the fix-snapshot-comment branch October 17, 2023 21:47
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants