Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibit cannot parse namespaces with string requires #242

Closed
filipesilva opened this issue Jan 5, 2021 · 0 comments · Fixed by #244
Closed

Kibit cannot parse namespaces with string requires #242

filipesilva opened this issue Jan 5, 2021 · 0 comments · Fixed by #244

Comments

@filipesilva
Copy link

Heya 👋

If you have a namespace with a string require, which is common in ClojureScript projects, the whole file will be skipped.

For instance, running kibit over this file:

(ns app.core
  (:require ["some-lib" :as some-lib]))

(not (empty? []))

Prints the following message:

Check failed -- skipping rest of file (./src/app/core.cljs:null:null)
Unparsable namespace form

It's possible to work around this by removing the require, running kibit, and then adding it back.

Would be nicer if the file was still checked, but that specific require ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant