Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kibit cannot parse ns with string requires #244

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Kibit cannot parse ns with string requires #244

merged 1 commit into from
Jan 5, 2022

Conversation

marksto
Copy link
Contributor

@marksto marksto commented Sep 13, 2021 •
edited
Loading

This is a minor enhancement that fixes: #242

@marksto
Copy link
Contributor Author

marksto commented Sep 13, 2021

@danielcompton, hello! Please, approve.

@marksto
Copy link
Contributor Author

marksto commented Dec 18, 2021

Hello again! Can I interest someone in merging this? @danielcompton or @jonase maybe? Thanks in advance!

@danielcompton danielcompton merged commit f92baf4 into clj-commons:master Jan 5, 2022
@danielcompton
Copy link
Member

Sorry for the delay!

@danielcompton
Copy link
Member

Would you be able to add a test for this too in a followup PR?

@marksto
Copy link
Contributor Author

marksto commented Jan 23, 2022

Um, sure!.. Sorry for the lack of one in the original PR.

@marksto marksto mentioned this pull request Jan 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kibit cannot parse namespaces with string requires
2 participants
@marksto @danielcompton