Avoid panicking in certain unsupported SQL paths #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, it was possible for certain CLI `spacetime sql` invocations to crash SpacetimeDB by including unsupported features. This was due to the SQL parser using the `todo!` macro, where it should have returned a `PlanError::Unsupported` error. With this commit, several uses of `todo!` are rewritten to instead return errors, which are translated appropriately into 400 responses, rather than crashing SpacetimeDB.
Centril
reviewed
Aug 1, 2023
Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Phoebe Goldman <phoebe@goldman-tribe.org>
Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Phoebe Goldman <phoebe@goldman-tribe.org>
Centril
approved these changes
Aug 1, 2023
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
Prior to this commit, it was possible for certain CLI `spacetime sql` invocations to crash SpacetimeDB by including unsupported features. This was due to the SQL parser using the `todo!` macro, where it should have returned a `PlanError::Unsupported` error. With this commit, several uses of `todo!` are rewritten to instead return errors, which are translated appropriately into 400 responses, rather than crashing SpacetimeDB.
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
Prior to this commit, it was possible for certain CLI `spacetime sql` invocations to crash SpacetimeDB by including unsupported features. This was due to the SQL parser using the `todo!` macro, where it should have returned a `PlanError::Unsupported` error. With this commit, several uses of `todo!` are rewritten to instead return errors, which are translated appropriately into 400 responses, rather than crashing SpacetimeDB.
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
Prior to this commit, it was possible for certain CLI `spacetime sql` invocations to crash SpacetimeDB by including unsupported features. This was due to the SQL parser using the `todo!` macro, where it should have returned a `PlanError::Unsupported` error. With this commit, several uses of `todo!` are rewritten to instead return errors, which are translated appropriately into 400 responses, rather than crashing SpacetimeDB.
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
Prior to this commit, it was possible for certain CLI `spacetime sql` invocations to crash SpacetimeDB by including unsupported features. This was due to the SQL parser using the `todo!` macro, where it should have returned a `PlanError::Unsupported` error. With this commit, several uses of `todo!` are rewritten to instead return errors, which are translated appropriately into 400 responses, rather than crashing SpacetimeDB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Prior to this commit, it was possible for certain CLI
spacetime sqlinvocations to crash SpacetimeDB by including unsupported features. This was due to the SQL parser using thetodo!macro, where it should have returned aPlanError::Unsupportederror.With this commit, several uses of
todo!are rewritten to instead return errors, which are translated appropriately into 400 responses, rather than crashing SpacetimeDB.API
If the API is breaking, please state below what will break