Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid panicking in certain unsupported SQL paths #121

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Avoid panicking in certain unsupported SQL paths #121

merged 3 commits into from
Aug 1, 2023

Commits on Aug 1, 2023

  1. Avoid panicking in certain unsupported SQL paths 

    Prior to this commit, it was possible for certain CLI `spacetime sql` invocations
to crash SpacetimeDB by including unsupported features.
This was due to the SQL parser using the `todo!` macro,
where it should have returned a `PlanError::Unsupported` error.

With this commit, several uses of `todo!` are rewritten
to instead return errors,
which are translated appropriately into 400 responses,
rather than crashing SpacetimeDB.
    @gefjon
    gefjon committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    f26d9c4 View commit details
    Browse the repository at this point in the history

  2. Add TODO comment 

    Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>
Signed-off-by: Phoebe Goldman <phoebe@goldman-tribe.org>
    @gefjon @Centril
    gefjon and Centril authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    6da8579 View commit details
    Browse the repository at this point in the history

  3. Add TODO comment 

    Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>
Signed-off-by: Phoebe Goldman <phoebe@goldman-tribe.org>
    @gefjon @Centril
    gefjon and Centril authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    8d6d9bb View commit details
    Browse the repository at this point in the history