Separate the global location of files per OS & create a configuration trait to read them #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
John, I would love to get this in soon. Or some other solution. Right now eg. |
kulakowski
reviewed
Aug 21, 2023
| @@ -15,6 +16,13 @@ cargo build -p spacetimedb-standalone | |||
| export STDB_PATH="${STDB_PATH:-$(mktemp -d)}" | |||
| mkdir -p "$STDB_PATH/logs" | |||
|
|
|||
| function cleanup { | |||
There was a problem hiding this comment.
@gefjon was this related (i.e., cleaning up the same stuff) that you were talking about earlier today as an ever growing pile of stuff in the temp dir?
There was a problem hiding this comment.
No, this appears to be unrelated.
|
Piotr, this is the PR that was just mentioned that we want to make sure is ok for cloud. |
Centril
requested changes
Aug 22, 2023
Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Mario Montoya <mamcx@elmalabarista.com>
Centril
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Was hardcoded in the location of
\stdbas the global database path.Here instead it use an adequate location per-OS and a configuration trait to read the location of the files, also for test.
API
If the API is breaking, please state below what will break