Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows Build #227

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Fix Windows Build #227

merged 1 commit into from
Aug 23, 2023

Conversation

jdetter
Copy link
Collaborator

@jdetter jdetter commented Aug 23, 2023

Description of Changes

API and ABI

  • This is a breaking change to the module ABI
  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

If the API is breaking, please state below what will break

@jdetter jdetter enabled auto-merge (squash) August 23, 2023 21:51
@jdetter jdetter merged commit 093c4b8 into master Aug 23, 2023
5 checks passed
mamcx
mamcx approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamcx mamcx mamcx approved these changes

@kulakowski kulakowski kulakowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdetter @mamcx @kulakowski