DataRef: borrow for great perf
#434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
a-little-less-clone
branch
3 times, most recently
from
417a012
to
99ceab0
Compare
joshua-spacetime
requested changes
Oct 17, 2023
kulakowski
reviewed
Oct 17, 2023
I have these flamegraphs, but I don't have a good way to upload them - the |
|
Uploading before and after screenshots of some flamegraphs that @gefjon generated. |
kulakowski
approved these changes
Oct 18, 2023
Centril
force-pushed
the
a-little-less-clone
branch
from
39ffcf6
to
25c43f5
Compare
joshua-spacetime
approved these changes
Oct 19, 2023
Centril
force-pushed
the
a-little-less-clone
branch
from
25c43f5
to
7d67701
Compare
…_table` (#436) * optimize delete, drop, rename * address review comments * even less cloning * more refactoring
Centril
force-pushed
the
a-little-less-clone
branch
from
7d67701
to
2f6e703
Compare
kulakowski
approved these changes
Oct 19, 2023
kulakowski
reviewed
Nov 8, 2023
|
|
||
| Ok(count) | ||
| let count = stdb.delete(tx, table_id, rows_to_delete); | ||
| NonZeroU32::new(count).ok_or(NodesError::ColumnValueNotFound) |
There was a problem hiding this comment.
I believe this introduced the new log lines we are discussing.
There was a problem hiding this comment.
Ah so we don't want this to be an error? Easy enough to return an u32 instead and remove line 164.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Get rid of the old
DataRefso that it instead borrows theDataKeyandProductValue.Then this is used throughout so that
iter,iter_by_col_eq,table_name_from_id, and friends, do not.clone()and instead just returns or works off of borrowed data.API and ABI
If the API is breaking, please state below what will break
Expected complexity level and risk
2