Optimize drop_table, rename_table, delete_by_col_eq, and clear_table
#436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/drop-rename-delete-opt
branch
from
417a012
to
85e21b3
Compare
kulakowski
reviewed
Oct 17, 2023
Centril
force-pushed
the
centril/drop-rename-delete-opt
branch
from
85e21b3
to
9ff9df9
Compare
Centril
changed the title
drop_table, rename_table, and delete_by_col_eqdrop_table, rename_table, delete_by_col_eq, and clear_table
kulakowski
approved these changes
Oct 18, 2023
Centril
added a commit
that referenced
this pull request
Oct 19, 2023
…_table` (#436) * optimize delete, drop, rename * address review comments
Centril
added a commit
that referenced
this pull request
Oct 19, 2023
…_table` (#436) * optimize delete, drop, rename * address review comments * even less cloning * more refactoring
Centril
added a commit
that referenced
this pull request
Oct 19, 2023
…_table` (#436) * optimize delete, drop, rename * address review comments * even less cloning * more refactoring
Centril
added a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
These functions and methods now clone less and collect keys/ids to rename/drop/delete rather than storing a cloned
ProductValuethat is then used to do the work.API and ABI
If the API is breaking, please state below what will break
Expected complexity level and risk
2