Don't allow double Channel#Open from clients (#614)

Fixes #604
cloudamqp · Dec 14, 2023 · 9ebffb5 · 9ebffb5
1 parent e1909f4
commit 9ebffb5
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/lavinmq/client/client.cr b/src/lavinmq/client/client.cr
@@ -312,9 +312,13 @@ module LavinMQ
     end
 
     private def open_channel(frame)
-      @channels[frame.channel] = Client::Channel.new(self, frame.channel)
-      @vhost.event_tick(EventType::ChannelCreated)
-      send AMQP::Frame::Channel::OpenOk.new(frame.channel)
+      if @channels.has_key? frame.channel
+        close_connection(frame, 504_u16, "CHANNEL_ERROR - second 'channel.open' seen")
+      else
+        @channels[frame.channel] = Client::Channel.new(self, frame.channel)
+        @vhost.event_tick(EventType::ChannelCreated)
+        send AMQP::Frame::Channel::OpenOk.new(frame.channel)
+      end
     end
 
     # ameba:disable Metrics/CyclomaticComplexity