Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against double open channel #604

Closed
carlhoerberg opened this issue Dec 4, 2023 · 1 comment · Fixed by #614
Closed

Protect against double open channel #604

carlhoerberg opened this issue Dec 4, 2023 · 1 comment · Fixed by #614
Labels

Comments

@carlhoerberg
Copy link
Member

Looks like there's no protection from the client opening the same channel twice:

private def open_channel(frame)
@channels[frame.channel] = Client::Channel.new(self, frame.channel)
@vhost.event_tick(EventType::ChannelCreated)
send AMQP::Frame::Channel::OpenOk.new(frame.channel)
end

@carlhoerberg
Copy link
Member Author

Not sure if it's allowed to double open a channel, but at least the channel object in lavinmq shouldn't be overwritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant