CloudEvents equality override #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 13, 2020 11:38
Signed-off-by: Curtis Mason <cumason@google.com>
Signed-off-by: Curtis Mason <cumason@google.com>
Signed-off-by: Curtis Mason <cumason@google.com>
grant
approved these changes
Aug 13, 2020
grayside
reviewed
Aug 13, 2020
| @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [1.0.1] | |||
There was a problem hiding this comment.
Is this a bug in that CloudEvents could not be compared, or a feature in providing a nice way to compare CloudEvents?
There was a problem hiding this comment.
cloudevent1 == cloudevent2would only test the memory address instead of an actual equality test because we forgot to override the __eq__ operator. I'd say both of the above are applicable :)
cumason123
added a commit
that referenced
this pull request
Aug 13, 2020
* docs: rename receiving cloudevents (#91) Signed-off-by: Grant Timmerman <timmerman+devrel@google.com> * add coc ref (#90) Signed-off-by: Doug Davis <dug@us.ibm.com> Co-authored-by: Curtis Mason <31265687+cumason123@users.noreply.github.com> * CloudEvents equality override (#98) * added tests to cloudevent eq Signed-off-by: Curtis Mason <cumason@google.com> * lint fix Signed-off-by: Curtis Mason <cumason@google.com> * modified changelog Signed-off-by: Curtis Mason <cumason@google.com> * version bump Signed-off-by: Curtis Mason <cumason@google.com> * cloudevent fields type checking adjustments (#97) * added exceptions and more indepth can_read Signed-off-by: Curtis Mason <cumason@google.com> * moved is_binary, is_structured into http module Signed-off-by: Curtis Mason <cumason@google.com> * changelog and version bump Signed-off-by: Curtis Mason <cumason@google.com> * removed unused import and spacing Signed-off-by: Curtis Mason <cumason@google.com> * lint fix Signed-off-by: Curtis Mason <cumason@google.com> * reverted auto format change Signed-off-by: Curtis Mason <cumason@google.com> * reverted changelog and auto format changes Signed-off-by: Curtis Mason <cumason@google.com> * changelog 1.0.1 update (#101) Signed-off-by: Curtis Mason <cumason@google.com> Co-authored-by: Grant Timmerman <timmerman@google.com> Co-authored-by: Doug Davis <dug@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Curtis Mason cumason@google.com
Fixes #93
Changes
Implemented CloudEvent.eq()
One line description for the changelog
CloudEvents equality override