-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudEvents equality override #98
Merged
cumason123
merged 4 commits into
cloudevents:v1.0.1-dev
from
cumason123:equality_overload
Aug 13, 2020
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
__version__ = "1.0.0" | ||
__version__ = "1.0.1" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
import pytest | ||
|
||
from cloudevents.http import CloudEvent | ||
|
||
|
||
@pytest.mark.parametrize("specversion", ["0.3", "1.0"]) | ||
def test_http_cloudevent_equality(specversion): | ||
attributes = { | ||
"source": "<source>", | ||
"specversion": specversion, | ||
"id": "my-id", | ||
"time": "tomorrow", | ||
"type": "tests.cloudevents.override", | ||
"datacontenttype": "application/json", | ||
"subject": "my-subject", | ||
} | ||
data = '{"name":"john"}' | ||
event1 = CloudEvent(attributes, data) | ||
event2 = CloudEvent(attributes, data) | ||
assert event1 == event2 | ||
# Test different attributes | ||
for key in attributes: | ||
if key == "specversion": | ||
continue | ||
else: | ||
attributes[key] = f"noise-{key}" | ||
event3 = CloudEvent(attributes, data) | ||
event2 = CloudEvent(attributes, data) | ||
assert event2 == event3 | ||
assert event1 != event2 and event3 != event1 | ||
|
||
# Test different data | ||
data = '{"name":"paul"}' | ||
event3 = CloudEvent(attributes, data) | ||
event2 = CloudEvent(attributes, data) | ||
assert event2 == event3 | ||
assert event1 != event2 and event3 != event1 | ||
|
||
|
||
@pytest.mark.parametrize("specversion", ["0.3", "1.0"]) | ||
def test_http_cloudevent_mutates_equality(specversion): | ||
attributes = { | ||
"source": "<source>", | ||
"specversion": specversion, | ||
"id": "my-id", | ||
"time": "tomorrow", | ||
"type": "tests.cloudevents.override", | ||
"datacontenttype": "application/json", | ||
"subject": "my-subject", | ||
} | ||
data = '{"name":"john"}' | ||
event1 = CloudEvent(attributes, data) | ||
event2 = CloudEvent(attributes, data) | ||
event3 = CloudEvent(attributes, data) | ||
|
||
assert event1 == event2 | ||
# Test different attributes | ||
for key in attributes: | ||
if key == "specversion": | ||
continue | ||
else: | ||
event2[key] = f"noise-{key}" | ||
event3[key] = f"noise-{key}" | ||
assert event2 == event3 | ||
assert event1 != event2 and event3 != event1 | ||
|
||
# Test different data | ||
event2.data = '{"name":"paul"}' | ||
event3.data = '{"name":"paul"}' | ||
assert event2 == event3 | ||
assert event1 != event2 and event3 != event1 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a bug in that CloudEvents could not be compared, or a feature in providing a nice way to compare CloudEvents?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would only test the memory address instead of an actual equality test because we forgot to override the
__eq__
operator. I'd say both of the above are applicable :)