Adjust AMQP spec to changes in #521 #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanconway
approved these changes
Oct 9, 2019
bad link now |
Merged
Adjusted the protocol binding to the definition of event format that is introduced in #521. Signed-off-by: Klaus Deissner <klaus.deissner@sap.com>
Removed the separate AMQP format definition Signed-off-by: Klaus Deissner <klaus.deissner@sap.com>
Worked on comments from the PR Signed-off-by: Klaus Deissner <klaus.deissner@sap.com>
duglin
reviewed
Oct 10, 2019
Signed-off-by: Klaus Deissner <klaus.deissner@sap.com>
|
LGTM |
|
Conditionally approved on the 10/10 call with a minor wording change that @deissnerk will make today. While this missed the 2-day deadline the group decided to approve it on the call and give people until end of day tomorrow (friday) to raise any concerns, then when we get 2 LGTMs we'll merge. |
… to what was discussed on the WG call. Signed-off-by: Klaus Deissner <klaus.deissner@sap.com>
Signed-off-by: Klaus Deissner <klaus.deissner@sap.com>
|
LGTM |
|
LGTM |
|
thanks @markpeek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR assumes the changes of #521 to be accepted and fixes #519. It renames the AMQP transport binding into protocol mapping.
With the clear definition of event format in the main spec, a separate AMQP event format became obsolete. I copied the type mapping for the attributes over to the AMQP protocol binding, where it is only relevant for the binary mode, and removed the AMQP format.