Rename files #533
Rename files #533
Conversation
duglin
force-pushed
the
renameFiles
branch
2 times, most recently
from
91d5a20 to
d27eaf3
Compare
|
CI errors are expected until merged. |
|
LGTM |
amqp-protocol-binding.md
Outdated
| @@ -30,7 +30,7 @@ This document is a working draft. | |||
|
|
|||
| ## 1. Introduction | |||
|
|
|||
| [CloudEvents][ce] is a standardized and transport-neutral definition of the | |||
| [CloudEvents][ce] is a standardized and protocol-neutral definition of the | |||
There was a problem hiding this comment.
I wonder, if protocol-agnostic sounds better, but I leave it up to you.
There was a problem hiding this comment.
ok I got all of these in all of the files
avro-format.md
Outdated
| @@ -18,7 +18,7 @@ This document is a working draft. | |||
|
|
|||
| ## 1. Introduction | |||
|
|
|||
| [CloudEvents][ce] is a standardized and transport-neutral definition of the | |||
| [CloudEvents][ce] is a standardized and protocol-neutral definition of the | |||
| @@ -35,8 +35,8 @@ those events. | |||
| The partitionkey attribute extension uses the key `partitionkey` for | |||
| in-memory formats. | |||
|
|
|||
| ### Transport format | |||
| ### Protocol format | |||
There was a problem hiding this comment.
I'm not sure if in-memory format vs. protocol format are still the right categories. What about stand-alone event format and protocol binding? Or structured-mode message vs. binary-mode message?
There was a problem hiding this comment.
This feels like more than a syntax fix so I'd prefer to leave that for a follow-on PR - if you want to open that one up
Signed-off-by: Doug Davis <dug@us.ibm.com>
|
Got 2 LGTMs and since this is just syntax fixes I'm going to merge. If anyone thinks there's something I missed or that a change was made incorrectly please raise an issue and we'll address it immediately. |
if #521 and #529 go in, then rename for consistency
Just look at the last commit to see the changes specific to this PR and not #521 and #529