Specify pnpm version in release action #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
reviewed
Jun 20, 2024
| # version is no longer being defined here, since we can automatically use the version | ||
| # defined in workers-sdk/package.json instead. | ||
| with: | ||
| version: 9.1.3 |
There was a problem hiding this comment.
Using ~9.1.3 or ^9.1.3 might delay the time when this will be broken next – or that syntax might be unsupported and just won't work, we can go ahead with this for now.
There was a problem hiding this comment.
Let's merge and see if this works on main, then we can change it to ^9.1.3 in a followup
fhanau
approved these changes
Jun 20, 2024
|
@petebacondarwin @CarmenPopoviciu #2256 was supposed to provide a durable fix here but didn't work. Based on https://github.com/pnpm/action-setup?tab=readme-ov-file#version the version field should being optional here, but it looks like the |
ns476
pushed a commit
to ns476/workerd
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Miniflare testing was broken and complaining about this. Not sure how to test without merging it in first, but CI is already broken on main so 🤷