Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify pnpm version in release action #2304

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Specify pnpm version in release action #2304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,8 @@ jobs:

- name: Install pnpm
uses: pnpm/action-setup@v3
# version is no longer being defined here, since we can automatically use the version
# defined in workers-sdk/package.json instead.
with:
version: 9.1.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ~9.1.3 or ^9.1.3 might delay the time when this will be broken next – or that syntax might be unsupported and just won't work, we can go ahead with this for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and see if this works on main, then we can change it to ^9.1.3 in a followup

- name: Use Node.js
uses: actions/setup-node@v4
with:
Expand Down
Loading