Update V8: 12.6 -> 12.7 #2342
Merged
Update V8: 12.6 -> 12.7 #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Jun 28, 2024
|
Based on https://chromium-review.googlesource.com/c/v8/v8/+/5600069 and https://chromium-review.googlesource.com/c/v8/v8/+/5596550 we should also update FP16 and abseil here to keep their versions in sync with V8. |
harrishancock
force-pushed
the
harris/update-v8-12.7
branch
from
7a77689
to
e0fd5ee
Compare
|
Thanks @fhanau, I added an Abseil and FP16 update. I also updated to V8 12.7.224.11, which is now the latest patch release. |
fhanau
approved these changes
Jul 3, 2024
|
The Windows build was stalled due to a transient bazel issue, I kicked it and it passed. PR LGTM. |
harrishancock
force-pushed
the
harris/update-v8-12.7
branch
5 times, most recently
from
36a8f6a
to
84519f2
Compare
V8 update from 12.6.228.7 -> 12.7.224.12. I noticed that V8 tests did not pass for either the current or new version of V8, and saw that our v8::Locker patch was to blame. I initially modified it to work, by exiting and re-entering in v8::Unlocker, but then decided to try just removing the patch entirely. All tests pass with it removed, so let's try. Removing the patch required adding a couple Isolate::Scopes in our code that were previously implicit. V8 12.7 also ships with the AsyncDispose symbol, so I removed our polyfill. Lastly, V8 now provides a SetFatalErrorHandler() function, which I call with our DCHECK-handling function. This will allow us to drop a separate patch from our internal repo.
This API was removed in V8 12.7, but we don't know how to safely replace our use of it yet.
With this new V8 commit, our Windows build broke with the following
error:
external/v8/src/heap/base/asm/x64/push_registers_asm.cc(24,2): error: "The masm based version must be used for Windows"
harrishancock
force-pushed
the
harris/update-v8-12.7
branch
from
84519f2
to
256bb63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates V8 from 12.6 to 12.7. My only concern here is the TracedReference dereferencing API removal. For now, I've just reverted the removal, and things seem to work -- but we need to find a way to move off of it soon.